Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: puppetlabs/puppetlabs-inifile
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2.2.0
Choose a base ref
...
head repository: puppetlabs/puppetlabs-inifile
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2.2.1
Choose a head ref
  • 16 commits
  • 9 files changed
  • 7 contributors

Commits on Jan 29, 2018

  1. Merge pull request #264 from puppetlabs/release

    Release mergeback 2.2.0
    pmcmaw authored Jan 29, 2018
    Configuration menu
    Copy the full SHA
    4220d85 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2018

  1. (maint) Fix spec tests on Windows

    Previously the spec tests were failing on Windows due to linux paths being used
    on a Windows platform.  This commit branches the test to use a correct absolute
    path depending on the type of platform that's actually running the test.  This
    is required as some functions within Puppet cannot be mocked correctly, such
    as path validation.
    glennsarti committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    7226d8c View commit details
    Browse the repository at this point in the history
  2. (maint) Remove hash-bang on test spec files

    Previously three ruby files in the spec unit and functions directories had the
    hash-bang prefix set to run these files using ruby. As these are rspec or rspec
    helper files, these would not be directly invoked via ruby anyway.  The rubocop
    rule Lint\ScriptPermission gets confused on Windows as this is unix convention.
    glennsarti committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    2855b98 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #265 from glennsarti/fix-windows

    (maint) Fix spec tests on Windows
    pmcmaw authored Jan 30, 2018
    Configuration menu
    Copy the full SHA
    bdee213 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2018

  1. inifile readme cleanup

    clairecadman committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    66e1d0c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fdeaef3 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2018

  1. Merge pull request #266 from clairecadman/inifile_readme_edit

    inifile readme cleanup
    Jean B authored Feb 1, 2018
    Configuration menu
    Copy the full SHA
    d2c38b9 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2018

  1. (MODULES-6687) puppet bug fixed

    There was a bug in Puppet <= 5.4.0 where values of attributes could never be false. If set to false, they would actually just be nil, or they would be true. This has been fixed in 5.5.0 and requires the applied change in this module. @resource[:refreshonly] will no longer be set to nil, so only checking for its existence is not enough. Instead, also check to make sure it is not :false
    eputnam committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    cb63479 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #268 from eputnam/modules6687

    (MODULES-6687) puppet bug fixed
    DavidS authored Feb 27, 2018
    Configuration menu
    Copy the full SHA
    4a5f394 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2018

  1. (MODULES-6687) actually fix refreshonly issue

    Instead of trying to anticipate output in the validation step, this makes sure the param is turned into a boolean value before validation.
    eputnam committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    b9c206f View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2018

  1. Merge pull request #269 from eputnam/modules6687

    (MODULES-6687) actually fix refreshonly issue
    david22swan authored Mar 5, 2018
    Configuration menu
    Copy the full SHA
    9b6b34f View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2018

  1. Configuration menu
    Copy the full SHA
    cc2ea79 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2018

  1. (MODULES-6723) change feature.microsoft_windows to Puppet::Util::Plat…

    …form.windows?
    
    Puppet::Util::Platform.windows? is the preferred check and is already in
    use by rspec-puppet.
    eputnam committed Apr 11, 2018
    Configuration menu
    Copy the full SHA
    bac5263 View commit details
    Browse the repository at this point in the history
  2. (MODULES-6723) workaround for spec test

    rspec-puppet currently prohibits the use of structured facts for
    'pretending' to be windows. this changes the failing test to use
    'osfamily' instead of ['os']['family'] so that it passes while a
    [PR](rodjek/rspec-puppet#675) is being reviewed.
    eputnam committed Apr 11, 2018
    Configuration menu
    Copy the full SHA
    1035568 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #270 from eputnam/release221

    (MODULES-6723) release prep for 2.2.1 and workaround for spec test
    david22swan authored Apr 11, 2018
    Configuration menu
    Copy the full SHA
    01a3a1c View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2018

  1. inifile README edits (#271)

    * inifile readme edits
    
    * Update README.markdown
    clairecadman authored and eputnam committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    d8a6aed View commit details
    Browse the repository at this point in the history
Loading