Less restrictive setting names #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I may have made this configuration file up
|
@johnsyweb I'm trying to figure out if there is some reason we need to have more restrictive regexes, but otherwise this looks good! 👍 |
|
🆒 |
cegeka-jenkins
pushed a commit
to cegeka/puppet-inifile
that referenced
this pull request
Oct 23, 2017
…ting-names Less restrictive setting names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[MODULES-1496] Less restrictive setting names in puppetlabs-inifile - Puppet Labs Tickets
An alternative approach to #110 / #123 and #131. With specs.
I've taken a similar approach to that of #115 in an effort to reduce the amount of maintenance required.