Modules 1876 - Setting names containing spaces fail #158

bmjen · 2015-03-31T21:31:35Z

When settings have a names containing spaces, the module fails to detect the existing setting and causes the creation of a duplicate setting.

e.g.
ini_setting { "passdb backend":
  ensure  => present,
  path    => '/etc/samba/smb.conf',
  section => 'global',
  setting => 'passdb backend',
  value   => 'tdbsam',
}

Results In:
[global]
passdb backend = tdbsam
passdb backend = tdbsam
passdb backend = tdbsam

Closes #155

…tting names.

cmurphy · 2015-03-31T21:41:48Z

spec/unit/puppet/util/ini_file_spec.rb

@@ -262,4 +262,25 @@
      subject.get_value("Drive names", "C:").should eq 'Winchester'
    end
  end
+context 'Configuration with spaces in setting names' do


I think this line needs to be indented two more spaces

…he middle

Modules 1876 - Setting names containing spaces fail

Fixed SETTING_REGEX and COMMENTED_SETTING_REGEX to allow spaces in se…

a747f66

…tting names.

cmurphy reviewed Mar 31, 2015
View reviewed changes

bmjen force-pushed the modules-1876-fix branch from 41a65aa to a394c10 Compare March 31, 2015 21:50

Adds acceptance testing for setting names containing white space in t…

69bee20

…he middle

bmjen force-pushed the modules-1876-fix branch from a394c10 to 69bee20 Compare March 31, 2015 22:28

tphoney added a commit that referenced this pull request Apr 1, 2015

Merge pull request #158 from bmjen/modules-1876-fix

5d70baf

Modules 1876 - Setting names containing spaces fail

tphoney merged commit 5d70baf into puppetlabs:master Apr 1, 2015

smortex added the bugfix label Jun 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modules 1876 - Setting names containing spaces fail #158

Modules 1876 - Setting names containing spaces fail #158

bmjen commented Mar 31, 2015

cmurphy Mar 31, 2015

Modules 1876 - Setting names containing spaces fail #158

Modules 1876 - Setting names containing spaces fail #158

Conversation

bmjen commented Mar 31, 2015

cmurphy Mar 31, 2015

Choose a reason for hiding this comment