Adding the ability to change regex match for $section in inifile #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate files with sections that don't follow [section_name] format. AIX for example uses section_name: format.
|
It would be great if you could add an acceptance test for this. Thanks for the work you have put in. |
|
@tphoney Yeah, I can do that. Also, I'll update the README to document the new attributes. |
|
fantastic ! +! |
|
@tphoney Added documentation and unit tests. |
|
Great work, could you please squash your commits. 8 commits looks a little ugly in the git history. Once again thanks. |
WhatsARanjit
force-pushed
the
MODULES-1940
branch
from
65da45a
to
b0fb47d
Compare
|
Squashed into one commit. |
|
@WhatsARanjit thanks |
tphoney
added a commit
that referenced
this pull request
Apr 21, 2015
Adding the ability to change regex match for $section in inifile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tickets.puppetlabs.com/browse/MODULES-1940
We have a customer that needs to manage a file on AIX. They tell us that AIX's configuration files commonly follow the format:
This file is basically an inifile, but instead of a section header of
...it is
The regex used to match section names is hard-coded. It would be great to specify the pattern to match section names.