MODULES-1599 Match only on space and tab whitespace after k/v separator #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous match for \s would also match on newlines. This caused existing settings with blank values to have the newline considered part of the whitespace surrounding the separator. When such settings are set with a value, the value ends up on the next line. Also adding acceptance test for this particular situation.
underscorgan
pushed a commit
that referenced
this pull request
Jun 22, 2015
MODULES-1599 Match only on space and tab whitespace after k/v separator
|
Great, thank you @misterdorm ! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous match for \s would also match on newlines. This caused
existing settings with blank values to have the newline considered part
of the whitespace surrounding the separator. When such settings are
set with a value, the value ends up on the next line.
Note that this update to @@SETTING_REGEX for matching only space
and tab, makes it consistent with @@COMMENTED_SETTING_REGEX
which already matches only on those two.
Also adding acceptance test for this particular situation.