Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Solaris 12 #172

Merged

Conversation

drewfisher314
Copy link

Fairly self-explanatory. This simply adds Solaris 12 to metadata.json.

@jonnytdevops
Copy link
Contributor

It would be appreciated if you could update the README for this module to indicated that Solaris 12 is compatible, but not supported by Puppet Labs (at this stage).

Thanks

@drewfisher314
Copy link
Author

Let me know if the wording is OK and I'll make the same change to the other PRs I submitted.

@jonnytdevops
Copy link
Contributor

This looks good to me, but please also squash your commits :)

Thanks

@drewfisher314
Copy link
Author

I think I messed up the squash ... I'm not very good at git yet. Any tips on squashing? I tried 'git rebase -i master' but I don't think that's right ...

@jonnytdevops
Copy link
Contributor

you were on the right track..

git rebase -i master
then replace the first letter with 'f' on the commit you want to squash up. Then save and exit the file. Then you have to git push --force to your github repo

Thanks

@drewfisher314
Copy link
Author

Thank you. That got it.

jonnytdevops added a commit that referenced this pull request Jun 23, 2015
@jonnytdevops jonnytdevops merged commit bf32ac8 into puppetlabs:master Jun 23, 2015
cegeka-jenkins pushed a commit to cegeka/puppet-inifile that referenced this pull request Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants