Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove brackets from ini_setting titles to workaround PUP-4709 #196

Merged
merged 1 commit into from
Feb 9, 2016

Conversation

domcleal
Copy link

@domcleal domcleal commented Feb 9, 2016

Puppet 4.0 and 4.1 are affected by PUP-4709 which raises duplicate
resource errors when using create_ini_settings(), due to the inclusion
of square brackets in the resource titles.

Error while evaluating a Function Call, Duplicate
declaration: Ini_setting[[foo] bar] is already declared; cannot
redeclare

Removing these from the function allows it to work on these Puppet
versions without error.

Replaces #195.

Puppet 4.0 and 4.1 are affected by PUP-4709 which raises duplicate
resource errors when using create_ini_settings(), due to the inclusion
of square brackets in the resource titles.

    Error while evaluating a Function Call, Duplicate
    declaration: Ini_setting[[foo] bar] is already declared; cannot
    redeclare

Removing these from the function allows it to work on these Puppet
versions without error.
@bmjen
Copy link
Contributor

bmjen commented Feb 9, 2016

Thanks @domcleal !

bmjen added a commit that referenced this pull request Feb 9, 2016
Remove brackets from ini_setting titles to workaround PUP-4709
@bmjen bmjen merged commit b79dd27 into puppetlabs:master Feb 9, 2016
@cdenneen
Copy link

cdenneen commented Mar 7, 2017

There are cases where the setting can be used more than once and a resource title of res["#{path} #{section} #{setting}"] wouldn't work in the case where you'd have something like:

[profile "home"]
source = /home/me
source = /root
exclude = .backup
exclude = .secretsauce

Is there anyway anyone can think of a way to make this work? Most of the ways I am thinking of could potentially leave bad entries say if you "update" a value later... it will just create a new one.

@smortex smortex added the bugfix label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants