Remove empty sections after last setting is removed #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| uncom = ment | ||
|
|
||
| -nonstandard- | ||
| shoes = purple |
There was a problem hiding this comment.
I moved these lines up to verify that the [section:sub] is not affected by removing a section.
hunner
force-pushed
the
remove_empty_section
branch
from
b6587ce
to
70b945a
Compare
Empty sections hanging around are not useful, so if the last line in a section is removed then remove the section. If the section still has comments, then just leave it be. This does not add the ability to remove sections that do not have settings to begin with; only allows cleaning a file as puppet makes changes to it.
hunner
force-pushed
the
remove_empty_section
branch
from
70b945a
to
2027a0b
Compare
| [section:sub] | ||
| subby=bar | ||
| #another comment | ||
| ; yet another comment | ||
|
|
||
| -nonstandard- |
There was a problem hiding this comment.
This section is now being removed, as it is empty after the setting is removed.
|
👍 thanks for this useful feature |
|
thanks! this will be very useful for https://review.openstack.org/#/c/280351/8/manifests/mon.pp |
|
👍 |
bmjen
added a commit
that referenced
this pull request
Mar 1, 2016
Remove empty sections after last setting is removed
|
@bmjen thanks a lot for your eyes on it! Thanks a lot for your help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty sections hanging around are not useful, so if the last line in a
section is removed then remove the section. If the section still has
comments, then just leave it be.
This does not add the ability to remove sections that do not have
settings to begin with; only allows cleaning a file as puppet makes
changes to it.