Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add insert_type and subsetting_key_val_separator #208

Merged
merged 1 commit into from Jul 21, 2016
Merged

Add insert_type and subsetting_key_val_separator #208

merged 1 commit into from Jul 21, 2016

Conversation

dmitryilyin
Copy link

@dmitryilyin dmitryilyin commented Jun 28, 2016 •
edited 

* Insert_type and imsert value can define where
  a new subsetting element will be placed.
* subsetting_key_val_separator allows you to have
  a separator character between a subsetting name
  and its value.
* Refactor ini_subsetting and its spec.

@dmitryilyin dmitryilyin force-pushed the master branch 5 times, most recently from ab78c38 to 4d23866 Compare June 29, 2016 12:58
@dmitryilyin dmitryilyin changed the title Add "insert_before", "insert_after", "insert_at" Add insert_type and subsetting_key_val_separator Jun 29, 2016
@dmitryilyin dmitryilyin force-pushed the master branch 2 times, most recently from 10bde0d to 0630a74 Compare June 29, 2016 13:25
@dmitryilyin
Copy link
Author

@DavidS could you please look

@dmitryilyin dmitryilyin force-pushed the master branch 2 times, most recently from 460bc7e to 357ecf8 Compare July 1, 2016 10:48
Add insert_type and subsetting_key_val_separator
357ecf8 
* Insert_type and insert value can define where
  a new subsetting element will be placed.
* subsetting_key_val_separator allows you to have
  a separator character between a subsetting name
  and its value.
* Refactor ini_subsetting and its spec.
@dmitryilyin
Copy link
Author

hello?

@DavidS DavidS merged commit 77022c5 into puppetlabs:master Jul 21, 2016
@DavidS
Copy link
Contributor

DavidS commented Jul 21, 2016

Awesome code! Thank you so much.

@dmitryilyin
Copy link
Author

Could you, please, make 1.5.1 tag?

@DavidS
Copy link
Contributor

DavidS commented Jul 22, 2016

I've scheduled a release for our next sprint.

cegeka-jenkins pushed a commit to cegeka/puppet-inifile that referenced this pull request Oct 23, 2017
@DavidS
Merge pull request puppetlabs#208 from dmitryilyin/master
8442fb7 
Add insert_type and subsetting_key_val_separator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dmitryilyin @DavidS @smortex