(MODULES-4932) fix for mimicking commented settings #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inifile, by design, looks for a commented version of a setting if an actual one does not exist. if one is found, it attempts to insert the new setting directly below its commented self and mimics the spacing used in the comment. this removes the mimicry and uses the designated key_val_separator instead.
|
soopa ! |
|
JFYI, This seems to have broken our CI as we're now getting Error: wrong number of arguments (3 for 4). https://bugs.launchpad.net/tripleo/+bug/1702134 |
apevec
pushed a commit
to redhat-openstack/rdoinfo
that referenced
this pull request
Jul 3, 2017
puppetlabs/puppetlabs-inifile#239 changed the number of parameters to set_value which is used by several puppet openstack configuration providers. This results in an error indicating wrong number of arguments. See Related-Bug https://bugs.launchpad.net/tripleo/+bug/1702134 Once we either switch from using inifile or update our providers, we will be able to unpin this. Change-Id: Ife139788e20aa2885e2487d7190bc8548d2d68e7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inifile, by design, looks for a commented version of a setting if an actual one does not exist. if one is found, it attempts to insert the new setting directly below its commented self and mimics the spacing used in the comment. this removes the mimicry and uses the designated key_val_separator instead.