(MODULES-5172) Backwards compatible ini_file.set_value #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix for MODULES-4932 was not backwards compatible as it changed the number of required parameters for the set_value function in the ini_file utility. This breaks anyone who were also extending the ini_setting providers and leveraging this function. This change updates the set_value function to still work with the previous 3 parameters while supporting the new format with 4 parameters.
|
Nice fix / change, i appreciate the work. Agreed you have hit an edge case where you are extending ini_setting, most users will not run into this problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix for MODULES-4932 (#239) was not backwards compatible as it changed the
number of required parameters for the set_value function in the ini_file
utility. This breaks anyone who were also extending the ini_setting
providers and leveraging this function. This change updates the
set_value function to still work with the previous 3 parameters while
supporting the new format with 4 parameters.