Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-6453) - PDK convert inifile #260

Merged
merged 4 commits into from Jan 25, 2018
Merged

Conversation

pmcmaw
Copy link
Contributor

@pmcmaw pmcmaw commented Jan 24, 2018

Using PDK to convert module so that it is compliant with the PDK.

The second commit addresses a bundler issue MODULES-6339.
The next time PDK convert is ran it will re-add the newer version of the bundler gem.

@pmcmaw
Copy link
Contributor Author

pmcmaw commented Jan 25, 2018

Currently failing on appveyor. There has been a test PR #262 to ensure Appveyor is not ran because I am adding an appveyor file. When this is merged, Appveyor will not run on other PRs.

Copy link
Contributor

@HelenCampbell HelenCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. Appveyor failing is due to external issues and is not enabled for the module.

@HelenCampbell HelenCampbell merged commit 518e4ac into puppetlabs:master Jan 25, 2018
cegeka-jenkins pushed a commit to cegeka/puppet-inifile that referenced this pull request Aug 5, 2021
(MODULES-6453) - PDK convert inifile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants