Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'ini_subsetting' custom resource type #29

Merged
merged 1 commit into from
Mar 25, 2013

Conversation

kbrezina
Copy link
Contributor

for handling settings which have more arguments such as

JAVA_ARGS="-Xmx192m -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=/var/log/pe-puppetdb/puppetdb-oom.hprof "

If you're ok with this approach I can add some rspec tests.

@cprice404
Copy link

@kbrezina thanks! this is awesome... I've been wanting to add something like this for a while and haven't been able to find time.

Two things:

  1. Can we expose a parameter for overriding the separator between subsettings? Right now you have it hard-coded to work with spaces, but I've seen variables that contain comma-separated values... I think your code would "just work" for those kinds of settings if we could override the separator.
  2. as you mentioned--tests.

Again--this is really awesome, thank you.

cprice404 added a commit that referenced this pull request Mar 25, 2013
Added 'ini_subsetting' custom resource type
@cprice404 cprice404 merged commit e824ab2 into puppetlabs:master Mar 25, 2013
cegeka-jenkins pushed a commit to cegeka/puppet-inifile that referenced this pull request Oct 23, 2017
Added 'ini_subsetting' custom resource type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants