(MODULES-7560) - removed spaces from the beginning or from the end of the value #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionce
force-pushed
the
MODULES-7560
branch
2 times, most recently
from
9350a36
to
40e8842
Compare
|
|
david22swan
reviewed
Nov 1, 2018
lib/puppet/type/ini_setting.rb
Outdated
| @@ -75,7 +75,13 @@ def munge_boolean_md5(value) | |||
| desc 'The value of the setting to be defined.' | |||
|
|
|||
| munge do |value| | |||
| value.to_s | |||
| if value.is_a?(Integer) | |||
There was a problem hiding this comment.
Couldn't the first two if's be folded into one with an OR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the value contains space characters at the beginning or at the end of the value, then the line will change at every puppet run. In order to fix it, i added strip to the value