(MODULES-8142) - Addition of support for SLES 15 #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tphoney
reviewed
Dec 14, 2018
Gemfile
Outdated
| @@ -28,7 +28,7 @@ group :development do | |||
| gem "puppet-module-win-dev-r#{minor_version}", require: false, platforms: [:mswin, :mingw, :x64_mingw] | |||
| gem "puppet-lint-i18n", require: false | |||
| gem "net-telnet", '0.1.0', require: false if Gem::Version.new(RUBY_VERSION.dup) < Gem::Version.new('2.3.0') | |||
| gem "net-telnet", require: false if Gem::Version.new(RUBY_VERSION.dup) >= Gem::Version.new('2.3.0') | |||
| gem "net-telnet", '0.1.1', require: false if Gem::Version.new(RUBY_VERSION.dup) >= Gem::Version.new('2.3.0') | |||
There was a problem hiding this comment.
also edit the .sync.yml or this will be lost. why the change ? does this clash with net-telnet in puppet agent ?
There was a problem hiding this comment.
.sync.yml still needs to be edited. Does this affect other modules ????
There was a problem hiding this comment.
Updated the sync file.
It conflicted with the specinfra gem as it pins net-telnet to 0.1.1
There was a problem hiding this comment.
Does this affect other modules ?
There was a problem hiding this comment.
Not that I've seen. inifile is the only one that seems to have net-telnet specifically set
|
do you have the results from the ad-hoc pipetline? |
net-telnet removed from gemfile as it was unneeded
|
|
cegeka-jenkins
pushed a commit
to cegeka/puppet-inifile
that referenced
this pull request
Aug 5, 2021
(MODULES-8142) - Addition of support for SLES 15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
net-telnet removed from gemfile as it does not need to be declared.