Puppet 4 functions #373
Merged
Puppet 4 functions #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #373 +/- ##
=========================================
- Coverage 89.26% 84.06% -5.2%
=========================================
Files 9 10 +1
Lines 596 634 +38
=========================================
+ Hits 532 533 +1
- Misses 64 101 +37
Continue to review full report at Codecov.
|
alexjfisher
added a commit
to alexjfisher/puppetlabs-inifile
that referenced
this pull request
Mar 3, 2020
In puppetlabs#373 the `create_ini_settings` function was ported to the new function API and namespaced. The boilerplate wasn't fixed up and the function didn't even work... This commit finishes the conversion with the following changes: * Remove the old API `puppet/parser/function` version. * Create a replacement non-namespaced, (but deprecated), new API shim that calls the namespaced version. * Replace argument validation in the function code with data-type based validation for the individual function parameters. * Use `call_function` instead of `function_create_resources`. * Update the README and REFERENCE.md files. * Test both shim and namespaced version of the function.
alexjfisher
added a commit
to alexjfisher/puppetlabs-inifile
that referenced
this pull request
Mar 3, 2020
In puppetlabs#373 the `create_ini_settings` function was ported to the new function API and namespaced. The boilerplate wasn't fixed up and the function didn't even work... This commit finishes the conversion with the following changes: * Remove the old API `puppet/parser/function` version. * Create a replacement non-namespaced, (but deprecated), new API shim that calls the namespaced version. * Replace argument validation in the function code with data-type based validation for the individual function parameters. * Use `call_function` instead of `function_create_resources`. * Update the README and REFERENCE.md files. * Test both shim and namespaced version of the function.
cegeka-jenkins
pushed a commit
to cegeka/puppet-inifile
that referenced
this pull request
Aug 5, 2021
In puppetlabs#373 the `create_ini_settings` function was ported to the new function API and namespaced. The boilerplate wasn't fixed up and the function didn't even work... This commit finishes the conversion with the following changes: * Remove the old API `puppet/parser/function` version. * Create a replacement non-namespaced, (but deprecated), new API shim that calls the namespaced version. * Replace argument validation in the function code with data-type based validation for the individual function parameters. * Use `call_function` instead of `function_create_resources`. * Update the README and REFERENCE.md files. * Test both shim and namespaced version of the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recreated #372 with a fork