Bug/master/better handling of quotes for subsettings #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 22, 2013 11:50
Prior to this commit, the `ini_subsetting` type assumed that all of the settings strings were quoted, and always wrote out the modified value with double-quotes around it. This commit adds tests for the case where the original setting is not quoted, and intelligently writes the modified setting with the same quote character (or lack thereof) that the original setting used.
cprice404
pushed a commit
that referenced
this pull request
May 22, 2013
…of-quotes-for-subsettings Bug/master/better handling of quotes for subsettings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.