(MAINT) Drop support for Solaris 10, Windows Server 2008 R2, and AIX 5.3 and 6.1 #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
suggested changes
Sep 15, 2022
There was a problem hiding this comment.
A refactor would be a change that doesn't change the functionality. This change does affect the behavior of tests, so I don't think "refactor" would be accurate for this change. As a user, I want a concise changelog entry, so I'd suggest a pull request title and commit message title more like "Drop support for CentOS 8, Solaris 10, Windows Server 2008 R2, and AIX 5.3 and 6.1".
jordanbreen28
changed the title
Thank you for the suggestion, the title has been updated. |
Prior to this commit the metadata.json file for this module listed OSs that are not supported by puppet agent as supported. This commit aims to refactor the metadata.json file to only list OSs that are supported by puppet agent. In this commit: Support for Solaris 10 was removed. Support for Windows Server 2008 R2 was removed. Support for AIX 5.3 and 6.1 was removed. The list of supported OSs can be found here: https://puppet.com/docs/pe/2021.7/supported_operating_systems.html
jordanbreen28
force-pushed
the
maint-os_refactor
branch
from
b284b71
to
745832d
Compare
jordanbreen28
changed the title
LukasAud
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit the metadata.json file for this module listed OSs that are not supported by puppet agent as supported. This commit aims to refactor the metadata.json file to only list OSs that are supported by puppet agent.
In this commit:
Support for Solaris 10 was removed.
Support for Windows Server 2008 R2 was removed.
Support for AIX 5.3 and 6.1 was removed.
The list of supported OSs can be found here:
https://puppet.com/docs/pe/2021.7/supported_operating_systems.html