Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CONT-783) - Add puppet 8 support/Drop puppet 6 support #505

Merged
merged 53 commits into from
Apr 11, 2023

Conversation

jordanbreen28
Copy link
Contributor

@jordanbreen28 jordanbreen28 commented Apr 5, 2023

This PR aims to update the module with compatibility for the upcoming
Puppet 8 agent release. The most relevant changes introduced in this
updated are:
Updated version requirements in metadata.json
Bumped Rubocop gems
Adjusted Rubocop configuration
Resolved new Rubocop offenses

@jordanbreen28 jordanbreen28 requested a review from a team as a code owner April 5, 2023 11:06
@puppet-community-rangefinder
Copy link

inifile::create_ini_settings is a function

Breaking changes to this file WILL impact these 3 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

ini_setting is a type

Breaking changes to this file MAY impact these 157 modules (near match):

This module is declared in 127 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@jordanbreen28 jordanbreen28 force-pushed the CONT-783-add_puppet8_support branch 5 times, most recently from 75ab0cc to 9e93676 Compare April 5, 2023 16:08
Copy link
Contributor

@GSPatton GSPatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks good to me. Pulled and tested locally.

@GSPatton GSPatton merged commit c905537 into main Apr 11, 2023
@GSPatton GSPatton deleted the CONT-783-add_puppet8_support branch April 11, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants