Add quote_char parameter to the ini_subsetting resource type #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The quote_char is used to quote the entire setting when it is modified
as a result of changes to some subsettings.
For an example let's assume we have a setting of this form:
JAVA_ARGS=-Xmx256m
and we want to add the '-Xms' parameter to the setting, for that purpose
we define a resource like this:
ini_subsetting { '-Xms':
ensure => present,
path => '/some/config/file',
section => '',
setting => 'JAVA_ARGS',
subsetting => '-Xms'
value => '256m',
}
which results into the following setting:
JAVA_ARGS=-Xmx256m -Xms256m
But this is not what we intended - if this setting is read by the bash
shell the '-Xms256m' parameter is interpreted as a command to be
executed rather than a value to be assigned to the JAVA_ARGS variable.
To fix this problem the quote_char parameter was added to the
ini_subsetting resource type, and we'll take advantage of it to fix the
problem in the above example like so:
ini_subsetting { '-Xms':
ensure => present,
path => '/some/config/file',
section => '',
setting => 'JAVA_ARGS',
quote_char => '"',
subsetting => '-Xms'
value => '256m',
}
which will result into:
JAVA_ARGS="-Xmx256m -Xms256m"
which is what we intended.
| @@ -48,6 +48,18 @@ | |||
| end | |||
| end | |||
|
|
|||
| newparam(:quote_char) do | |||
| desc 'The character used to quote the entire value of the setting. ' + | |||
| %q{Vaild vaules are '', '"' and "'". Defaults to ''.} | |||
There was a problem hiding this comment.
couple of typoes at the start, Valid values
apenney
pushed a commit
that referenced
this pull request
May 16, 2014
…ter-for-subsetting Add quote_char parameter to the ini_subsetting resource type
cegeka-jenkins
pushed a commit
to cegeka/puppet-inifile
that referenced
this pull request
Oct 23, 2017
…har-parameter-for-subsetting Add quote_char parameter to the ini_subsetting resource type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The quote_char is used to quote the entire setting when it is modified as a result of changes to some subsettings.
For an example let's assume we have a setting of this form:
and we want to add the
-Xmsparameter to the setting, for that purpose we define a resource like this:which results into the following setting:
But this is not what we intended - if this setting is read by the bash shell the
-Xms256mparameter is interpreted as a command to be executed rather than a value to be assigned to the JAVA_ARGS variable.To fix this problem the quote_char parameter was added to the ini_subsetting resource type, and we'll take advantage of it to fix the problem in the above example like so:
which will result into:
JAVA_ARGS="-Xmx256m -Xms256m"which is what we intended.