Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up rspec deprecation warnings. #166

Merged

Conversation

alexharv074
Copy link
Contributor

No description provided.

@tphoney tphoney closed this Apr 13, 2016
@tphoney tphoney reopened this Apr 13, 2016
@tphoney
Copy link
Contributor

tphoney commented Apr 13, 2016

@alexharv074 apologies for the close and reopen. accidental click

@tphoney
Copy link
Contributor

tphoney commented Apr 13, 2016

Great work !!

@tphoney tphoney merged commit 3fa562a into puppetlabs:master Apr 13, 2016
@alexharv074
Copy link
Contributor Author

@tphoney Not sure if you noticed but the build was red before the merge.

  incompatible OSs
    is_expected.to fail on windows 8.1 (FAILED - 1)
    is_expected.to fail on Darwin 13.3.0 (FAILED - 2)
    is_expected.to fail on AIX 7100-02-00-000 (FAILED - 3)
    is_expected.to fail on AIX 6100-07-04-1216 (FAILED - 4)
    is_expected.to fail on AIX 5300-12-01-1016 (FAILED - 5)

Was that something that was already broken? I don't see how my change would have caused that.

@tphoney
Copy link
Contributor

tphoney commented Apr 13, 2016

I sure did :) #168 will fix this issue. Thanks for being vigilant. @alexharv074

@alexharv074
Copy link
Contributor Author

Great thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants