Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on Centos support for https://github.com/garethr/riemann-vagrant I noticed that just using:
Would fail on Centos 5.8 and 6.3 (using the Puppetlabs provided vagrant boxes) with an incorrect package name. The README indicates this module supports 5.3.
Checking those two boxes using yum seems to indicate that the openjdk packages are available so I've added additional logic to detect those specific versions of Centos and if found choose a relevant package in to the same way as the ubuntu logic.
I've also added tests just for this functionality (the module previously had no test suite). Two of the tests verify the backwards compatibility for 5.3, the other two the new (working) behaviour for 5.8. and 6.3.