Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized code for making java::oracle atomic. Fixes MODULES-8085 #330

Merged
merged 2 commits into from
Oct 12, 2018
Merged

Optimized code for making java::oracle atomic. Fixes MODULES-8085 #330

merged 2 commits into from
Oct 12, 2018

Conversation

dploeger
Copy link
Contributor

No description provided.

@david22swan
Copy link
Member

@dploeger Your code is currently failing a syntax check, other than that the change looks good to me.

Offenses:
spec/defines/oracle_spec.rb:186:13: C: Layout/IndentHash: Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
            ensure: 'present',
            ^^^^^^^^^^^^^^^^^
spec/defines/oracle_spec.rb:279:13: C: Layout/IndentHash: Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
            ensure: 'present',
            ^^^^^^^^^^^^^^^^^

@dploeger
Copy link
Contributor Author

@david22swan Oh, right. Sorry. Fixed that.

@david22swan
Copy link
Member

screen shot 2018-10-12 at 2 47 17 pm

@david22swan david22swan merged commit 61ffb4b into puppetlabs:master Oct 12, 2018
@dploeger dploeger deleted the MODULES-8085 branch October 15, 2018 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants