Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to override basedir and package type for oracle java #345

Merged
merged 3 commits into from
Feb 12, 2019
Merged

Add ability to override basedir and package type for oracle java #345

merged 3 commits into from
Feb 12, 2019

Conversation

fraenki
Copy link
Contributor

@fraenki fraenki commented Feb 12, 2019

This is a resubmission of #298, because it looks like the original submitter lost interest.
In addition this fixes several small issues of the original submission:

  • fix tests (the Exec was missing the full version information)
  • use evaluated/os-dependent paths from $_basedir instead of hardcoded values

ping @david22swan

@david22swan
Copy link
Member

screen shot 2019-02-12 at 3 19 02 pm

@david22swan
Copy link
Member

@fraenki All looks good to me, thanks for putting in the work to get this finished. :)

@david22swan david22swan merged commit 7bede1a into puppetlabs:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants