Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default version & java 8 version from 8u192 to 8u201 #347

Merged
merged 3 commits into from
Feb 25, 2019
Merged

Update default version & java 8 version from 8u192 to 8u201 #347

merged 3 commits into from
Feb 25, 2019

Conversation

valentinsavenko
Copy link
Contributor

It seems Oracle is no longer offering the old 192 version for download. Which makes this module fail with the default values!

Valentin Savenko added 2 commits February 21, 2019 14:00
It seems Oracle is no longer offering the old 192 version for download. Which makes this module fail with the default values!
@eimlav
Copy link
Contributor

eimlav commented Feb 25, 2019

Hey @valentinsavenko. Thanks for updating the Oracle versions. Could you also update the values in spec/acceptance/install_spec.rb? Cheers!

@eimlav eimlav added the feature label Feb 25, 2019
@eimlav
Copy link
Contributor

eimlav commented Feb 25, 2019

Adhoc ran successfully so I will merge this now. Thanks for your PR @valentinsavenko :)

screen shot 2019-02-25 at 10 01 44

@eimlav eimlav merged commit 5509042 into puppetlabs:master Feb 25, 2019
@valentinsavenko
Copy link
Contributor Author

nice 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants