Add support for java 11, the default in debian buster 10 #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhooyberghs
force-pushed
the
feature/java11
branch
from
43e9d5a
to
197213e
Compare
|
Thank you @jhooyberghs for submitting the PR. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to implement the current master branch in our setup, I noticed the facts don't work for debian buster since the output format of the default openjdk 11 command "java -version" changed. I added a condition to check the format, and see if it starts with 1 (like in 1.8.0_144) or the newer format with > 1 (like 11.0.4).
This adds the java version facts resolving for debian buster and should not break it for existing implementations.