Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-10681) Add option to manage symlink to java::adopt #429

Merged
merged 1 commit into from
May 27, 2020
Merged

(MODULES-10681) Add option to manage symlink to java::adopt #429

merged 1 commit into from
May 27, 2020

Conversation

fraenki
Copy link
Contributor

@fraenki fraenki commented May 26, 2020

https://tickets.puppetlabs.com/browse/MODULES-10681

This is a follow-up to #348 and #370:
It adds the capability to manage a symlink to the AdoptJDK defined type. (The same functionality is already available in java::download.)

This was supposed to be included in PR #370, but it slipped through.

While here, convert the documentation to Puppet Strings and add some basic unit tests.

While here, convert the documentation to Puppet Strings and add
some basic unit tests.
@fraenki fraenki requested a review from a team as a code owner May 26, 2020 14:26
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@236a115). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #429   +/-   ##
=========================================
  Coverage          ?   73.68%           
=========================================
  Files             ?        5           
  Lines             ?       57           
  Branches          ?        0           
=========================================
  Hits              ?       42           
  Misses            ?       15           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 236a115...06f1a56. Read the comment docs.

@pmcmaw
Copy link
Contributor

pmcmaw commented May 27, 2020

Hey @fraenki
Thanks for such a great PR.
Merging now.

@pmcmaw pmcmaw merged commit c481a12 into puppetlabs:master May 27, 2020
@pmcmaw pmcmaw added the feature label May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants