Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SAP Java (sapjvm / sapmachine) #433

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Add support for SAP Java (sapjvm / sapmachine) #433

merged 1 commit into from
Jul 15, 2020

Conversation

timdeluxe
Copy link
Contributor

In big companies you might need to install the SAP flavours of Java, because their products require it. Usually their product installers do it themselves but in certain cases (f.e. when using SAP commerce, in former times called Hybris) you might need to install it by yourself - at least in our company.

This PR extends the puppet module to support installing those Javas.

@timdeluxe timdeluxe requested a review from a team as a code owner July 14, 2020 15:39
@puppet-community-rangefinder
Copy link

java::sap is a type

that may have no external impact to Forge modules.

This module is declared in 79 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@cb1632a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #433   +/-   ##
=========================================
  Coverage          ?   82.45%           
=========================================
  Files             ?        5           
  Lines             ?       57           
  Branches          ?        0           
=========================================
  Hits              ?       47           
  Misses            ?       10           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb1632a...24ca4a6. Read the comment docs.

@daianamezdrea
Copy link
Contributor

Hi @timdeluxe, nice work! Thank you for your contribution! Cheers!

@daianamezdrea daianamezdrea merged commit f991317 into puppetlabs:master Jul 15, 2020
@sanfrancrisko sanfrancrisko changed the title Support SAP Javas (sapjvm / sapmachine) Add support for SAP Java (sapjvm / sapmachine) Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants