Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-10935) - Switch legacy operatingsystem fact to modern kernel one #461

Merged
merged 2 commits into from
Feb 17, 2021

Conversation

rjd1
Copy link
Contributor

@rjd1 rjd1 commented Feb 8, 2021

No description provided.

@rjd1 rjd1 requested a review from a team as a code owner February 8, 2021 11:32
@pmcmaw
Copy link
Contributor

pmcmaw commented Feb 15, 2021

Hey @rjd1

I would like to thank you for your PR, however it is causing failures in the unit tests, if you would have time to address this I would be more than happy to get your change merged.

Thank you for taking the time to submit this. :-)

@rjd1
Copy link
Contributor Author

rjd1 commented Feb 17, 2021

Hi @pmcmaw

I've updated the corresponding spec file to reflect the fact change. It looks like all checks are passing now. Thanks!

@pmcmaw
Copy link
Contributor

pmcmaw commented Feb 17, 2021

Thanks for that @rjd1
Merging :-)

@pmcmaw pmcmaw merged commit 2ee840b into puppetlabs:main Feb 17, 2021
@pmcmaw pmcmaw added the bugfix label Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants