Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdksync - Remove Puppet 5 from testing and bump minimal version to 6.0.0 #463

Merged
merged 5 commits into from
Feb 18, 2021

Conversation

carabasdaniel
Copy link
Contributor

Remove Puppet 5 from testing and bump minimal version to 6.0.0
pdk version: 1.19.0.pre (47)

@codecov-io
Copy link

Codecov Report

Merging #463 (0d2dda5) into main (57187de) will decrease coverage by 7.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #463      +/-   ##
==========================================
- Coverage   82.45%   75.43%   -7.02%     
==========================================
  Files           5        5              
  Lines          57       57              
==========================================
- Hits           47       43       -4     
- Misses         10       14       +4     
Impacted Files Coverage Δ
lib/facter/java_libjvm_path.rb 83.33% <ø> (ø)
lib/facter/java_major_version.rb 88.88% <ø> (ø)
lib/facter/java_patch_level.rb 44.44% <ø> (-44.45%) ⬇️
lib/facter/java_version.rb 73.33% <0.00%> (ø)
lib/facter/java_default_home.rb 83.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c03f5a0...0d2dda5. Read the comment docs.

@DavidS DavidS merged commit 0ee1993 into main Feb 18, 2021
@DavidS DavidS deleted the pdksync_remove_puppet5 branch February 18, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants