Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add url parameter for adoptopenjdk #473

Merged
merged 2 commits into from
Apr 26, 2021
Merged

add url parameter for adoptopenjdk #473

merged 2 commits into from
Apr 26, 2021

Conversation

cbobinec
Copy link
Contributor

Hi,

when using AdoptOpenJDK, there is currently no possibility to download tar.gz from an internal repository, instead of github.com/AdoptOpenJDK.
For this purpose, an URL parameter already exists for oracleJDK (download.pp). This PR do the same for adoptopenjdk.
Thanks

@cbobinec cbobinec requested a review from a team as a code owner March 23, 2021 08:07
@CLAassistant
Copy link

CLAassistant commented Mar 23, 2021

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link

java::adopt is a type

that may have no external impact to Forge modules.

This module is declared in 79 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@daianamezdrea
Copy link
Contributor

Hi @cbobinec, the changes are looking great! One small thing, could you add a small description in the documentation in order to reflect the changes? Thank you ! Cheers!

@cbobinec
Copy link
Contributor Author

Hi @daianamezdrea ! Sorry this is my first Puppet contribution :)
By documentation you mean just update REFERENCE.md with this new parameter ?
Or is there any other documentation to update ?
Thanks !

@cbobinec
Copy link
Contributor Author

cbobinec commented Apr 2, 2021

Hi, REFERENCE.md is now up-to-date thanks to Puppet Strings

@cbobinec
Copy link
Contributor Author

cbobinec commented Apr 8, 2021

Hi, not sure to understand why "PR Testing / RedHat-8, puppet6-nightly" is the only one failing, and, is there anything I can do ?

@daianamezdrea
Copy link
Contributor

Hi @cbobinec, sorry for my delayed answer, I'll try to solve now the problem for RedHat-8, puppet6-nightly

@daianamezdrea
Copy link
Contributor

All good, it only needed a re-run (because of a timeout error unrelated with your changes from the PR) and everything is green now! Yes, that was what I meant with the documentation, perfect! Thank you and happy first contribution ! Cheers!

@daianamezdrea daianamezdrea merged commit 01fba18 into puppetlabs:main Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants