-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add url parameter for adoptopenjdk #473
Conversation
java::adopt is a typethat may have no external impact to Forge modules. This module is declared in 79 of 576 indexed public
|
|
Hi @cbobinec, the changes are looking great! One small thing, could you add a small description in the documentation in order to reflect the changes? Thank you ! Cheers! |
|
Hi @daianamezdrea ! Sorry this is my first Puppet contribution :) |
|
Hi, REFERENCE.md is now up-to-date thanks to Puppet Strings |
|
Hi, not sure to understand why "PR Testing / RedHat-8, puppet6-nightly" is the only one failing, and, is there anything I can do ? |
|
Hi @cbobinec, sorry for my delayed answer, I'll try to solve now the problem for RedHat-8, puppet6-nightly |
|
All good, it only needed a re-run (because of a timeout error unrelated with your changes from the PR) and everything is green now! Yes, that was what I meant with the documentation, perfect! Thank you and happy first contribution ! Cheers! |
Hi,
when using AdoptOpenJDK, there is currently no possibility to download tar.gz from an internal repository, instead of github.com/AdoptOpenJDK.
For this purpose, an URL parameter already exists for oracleJDK (download.pp). This PR do the same for adoptopenjdk.
Thanks