Skip to content

Conversation

dploeger
Copy link
Contributor

@dploeger dploeger commented Dec 3, 2021

This adds support for Adoptium Temurin (the new name of Adopt OpenJDK). I started testing from Adoptium 16 onwards, because previous versions can still be fetched from Adopt.

fixes MODULES-11234

@dploeger dploeger requested a review from a team as a code owner December 3, 2021 06:31
@CLAassistant
Copy link

CLAassistant commented Dec 3, 2021

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link

java::adoptium is a type

that may have no external impact to Forge modules.

This module is declared in 79 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@dploeger dploeger force-pushed the modules-11234 branch 2 times, most recently from 0b7b7c8 to 63e6df8 Compare December 3, 2021 06:50
@dploeger dploeger changed the title (MODULES-11234) Support Adoptium Temirum (MODULES-11234) Support Adoptium Temurin Dec 3, 2021
@dploeger
Copy link
Contributor Author

dploeger commented Jan 3, 2022

Can this perhaps be merged now?

@chelnak chelnak closed this Mar 10, 2022
@chelnak chelnak reopened this Mar 10, 2022
@puppet-community-rangefinder
Copy link

java::adoptium is a type

that may have no external impact to Forge modules.

This module is declared in 79 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry for the wait on getting this merged in but everything looks great to me so I'll go ahead and do so now.

@david22swan david22swan merged commit d36a0f6 into puppetlabs:main Mar 10, 2022
@dploeger
Copy link
Contributor Author

dploeger commented Apr 4, 2022

@david22swan Thanks. Any idea when this gets released on the forge?

@david22swan
Copy link
Member

There is no plan for one currently but will pass on that it has been requested.

@david22swan
Copy link
Member

@dploeger Happy to report that the module has now been released, though as it was a x release you won't be able to pull it down automatically sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants