Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for aarch64 architecture download #516

Merged
merged 2 commits into from
May 16, 2022

Conversation

0Rick0
Copy link
Contributor

@0Rick0 0Rick0 commented May 16, 2022

fixes #514

@0Rick0 0Rick0 requested a review from a team as a code owner May 16, 2022 16:10
@puppet-community-rangefinder
Copy link

java::download is a type

Breaking changes to this file WILL impact these 1 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

This module is declared in 79 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@CLAassistant
Copy link

CLAassistant commented May 16, 2022

CLA assistant check
All committers have signed the CLA.

manifests/download.pp Outdated Show resolved Hide resolved
Copy link
Contributor

@chelnak chelnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small question on a key name

@0Rick0 0Rick0 requested a review from chelnak May 16, 2022 16:53
Copy link
Contributor

@chelnak chelnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests are green - LGTM!

@chelnak chelnak merged commit 5ebefbf into puppetlabs:main May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AArch64 support
5 participants