Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package naming to differentiate between minor versions #534

Merged
merged 4 commits into from
Nov 7, 2022

Conversation

sd-z
Copy link
Contributor

@sd-z sd-z commented Nov 2, 2022

Hi there,
I have opened up a new PR as the old one proved to be near to impossible to get through CLA as it included two different accounts. The old PR can be found here: #533
Best regards,

@puppet-community-rangefinder
Copy link

java::download is a type

Breaking changes to this file WILL impact these 2 modules (exact match):

This module is declared in 79 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@sd-z sd-z marked this pull request as ready for review November 2, 2022 14:12
@sd-z sd-z requested a review from a team as a code owner November 2, 2022 14:12
@sd-z
Copy link
Contributor Author

sd-z commented Nov 2, 2022

As mentioned in the other PR I will look into the failing Spec Tests.

@sd-z
Copy link
Contributor Author

sd-z commented Nov 3, 2022

I rewrote the rspec test values to fit the new archive naming. Tests should run successfully now.

Copy link
Contributor

@jordanbreen28 jordanbreen28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sd-z!
Thanks for all your work on this.
Happy to approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants