Unresolved fact fix #539
Merged
Unresolved fact fix #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, when run on non-darwin systems with no java installed, the custom fact java_version was unresolved. This was due to an incorrect return type set in lib/facter/java_version.rb (returned a boolean). This commit hopes to rectify this issue, by ensuring that the returned value for java_version is in the correct format.
jordanbreen28
force-pushed
the
538-unresolved-fact-fix
branch
from
c79ff4b
to
d5bbc7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, when run on non-darwin systems with no java installed, the custom fact java_version was unresolved.
This was due to an incorrect return type set in
lib/facter/java_version.rb (returned a boolean) as oppose to a string/nil.
This PR hopes to rectify this issue, by ensuring that the returned value for java_version is in the correct format.