538-unresolved-fact-fix #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanbreen28
force-pushed
the
538-unresolved-fact-fix
branch
from
d50c1a3
to
5ed1e9c
Compare
jordanbreen28
changed the title
jordanbreen28
force-pushed
the
538-unresolved-fact-fix
branch
from
5ed1e9c
to
4dccd47
Compare
Fix for issue #538
jordanbreen28
force-pushed
the
538-unresolved-fact-fix
branch
from
4dccd47
to
d4d43c1
Compare
jordanbreen28
force-pushed
the
538-unresolved-fact-fix
branch
from
c7210c7
to
40bbbe1
Compare
jordanbreen28
force-pushed
the
538-unresolved-fact-fix
branch
from
40bbbe1
to
aba7337
Compare
GSPatton
reviewed
Nov 28, 2022
GSPatton
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #538
Prior to this PR, work was carried out to update the use of Facter in this module, as the methods present had been deprecated.
This change a bug, as the Facter::Util::Resolution (deprecated) and Facter::Core::Execution (supported) do not behave the same.
Previously, the deprecated Facter::Util::Resolution.exec statements initially ran a which, that checked that the binary was present before running an exec statement on that binary. The newer instances of Facter's execute statements, attempted to execute even when the binary is not present, which causes an error.
This PR hopes to rectify this issue, by first running a command which checks if the binary is present before executing.