Release mergeback

…nvalid_password

support removal of keystore file if password incorrect

(MODULES-4833) Update to Puppet version dependancy

(MODULES-5144) Prep for puppet 5

This commit fixes installing java on windows in the acceptance tests
by moving the installation logic to the spec_helper_acceptance so that
java is always installed when needed, and removes basic_spec.rb because
having the installation logic in one spec file means all spec files must
be run in order to have a properly setup environment.

This commit also migrates the java install from using windows_java to
puppetlabs-chocolatey. This follows a standard at Puppet to use chocolatey
in acceptance to setup an environment.

This commit fixes the path to java because the jdk package installed
by chocolatey uses 'C:\Program Files' instead of a custom path. The spaces
cause errors, so we properly quote them in order for the command to work.

(MODULES-5187) mysnc puppet 5 and ruby 2.4

This commit refactors OS specific parameters to be more maintainable.  Instead
if have many case statements, a common target and target_dir is used.

…stall-on-windows-in-acceptance

fix java install on windows in acceptance

(maint) modulesync 915cde70e20

Previously the acceptance tests installed JDK from the chocolatey pacakge repo
however the version of the installed pacakges was not enforced and the
calculation for the Java path then fails as it is expected java 8u131.  This
commit pins the JDK8 pacakged to the latest 8u141 in the chocolatey repo and
updates the java version logic with the new version number.

(MODULES-5357) Pin JDK installation pacakge to 8.0.144

Removing older version of Ubuntu that are not supported by the module.

(MODULES-5501) - Remove unsupported Ubuntu

(maint) modulesync 892c4cf

Rubocop cleanup of java_ks type

Add Java 9 support

New ':source_password' param to provide PKCS12 password.
Added unit and acceptance tests.

Add support for importing PKCS12 files.

This includes the removal of Sles 10, Debian 6 and Windows 2003.
Debian 9 has been added.

Update metadata

Microsoft no longer supports Windows 8 as an OS.

(MODULES-5814) - Removing Windows 8

FM-6517 On SLES we do not have pkcs12 installed

Previously the acceptance tests installed JDK from the chocolatey package repo
and pinned the version to `8.0.144`; however, that package now fails to install
due to a 404 error in the download. This commit updates the version pin to
`8.0.152`, which is the latest stable release and which installs correctly.

The shell string in the it block of the pkcs12 acceptance tests does
not include escaped quoting around the path to `keytool` prior to
this commit. This causes a failure on windows because the path includes
a space. This commit wraps the path to keytool in escaped quotes to
resolve the issue.

Adding appveyor config file

Prior to this commit, the unit tests for java_ks could never pass
on windows due to use of linux paths and commands hard-coded. This
commit adds a variable for the temp paths in both spec test files
and guards against running tests that rely on linux commands on a
windows machine.

…ix-windows-acceptance

(FM-6457) Fix Windows CI

Planning on putting java_ks under windows management in modulesync.
Therefore I want to keep the appveyor file to run tests against Windows
on every merge.

(maint) - Updating flag to stop appveyor config from being deleted

(maint) - modulesync 1d81b6a

(FM-6588) - Remove vulnerable puppet3 support dependencies (modulesync  e6d4a7d)

(MODULES-6161) - Release Prep for 2.0.0