Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error: parameter 'api_server_count' expects an Integer value, got… #113

Merged
merged 3 commits into from
Jun 13, 2018

Conversation

Lord-Y
Copy link
Contributor

@Lord-Y Lord-Y commented Jun 7, 2018

All in the title and test are okay:

Finished in 3.83 seconds (files took 1.22 seconds to load)
64 examples, 0 failures

Total resources: 50
Touched resources: 33
Resource coverage: 66.00%
Untouched resources:

Class[Kubernetes::Params]
File[/etc/kubernetes/manifests]
File[/etc/kubernetes/pki/ca.crt]
File[/etc/kubernetes/pki/ca.key]
File[/etc/kubernetes/pki/etcd/ca.crt]
File[/etc/kubernetes/pki/etcd/ca.key]
File[/etc/kubernetes/pki/etcd/client.crt]
File[/etc/kubernetes/pki/etcd/client.key]
File[/etc/kubernetes/pki/etcd/peer.crt]
File[/etc/kubernetes/pki/etcd/peer.key]
File[/etc/kubernetes/pki/etcd/server.crt]
File[/etc/kubernetes/pki/sa.pub]
File[/etc/kubernetes/pki]
File[/etc/kubernetes]
File_line[set systemd cgroup docker]
Kubernetes::Kubeadm_init[yohann-virtual-machine]
Kubernetes::Kubeadm_join[yohann-virtual-machine]
Coverage report generated for RSpec to /data/home/yohann/github/puppetlabs-kubernetes/coverage. 504 / 987 LOC (51.06%) covered.
Coverage report generated for RSpec to /data/home/yohann/github/puppetlabs-kubernetes/coverage/coverage.json. 504 / 987 LOC (51.06%) covered.
Coverage report Rcov style generated for RSpec to /data/home/yohann/github/puppetlabs-kubernetes/coverage/rcov

Copy link
Contributor

@davejrt davejrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davejrt
Copy link
Contributor

davejrt commented Jun 13, 2018

@Lord-Y are you using the kubetool? the api server count is generated by this, and assuming that someone doesn't want to run a single controller isn't something we want to set as a default. Also the etcd token and the join token k8s are not the same thing, so shouldn't be using the same param. Can you raise an issue with the specific errors and how to reproduce them so we can look into them further?

@Lord-Y
Copy link
Contributor Author

Lord-Y commented Jun 16, 2018

@davejrt at the beginning I generated all certificates and that's when I encoutered the issue. Some days after, I use the kubetool and everything was perfect.

@davejrt davejrt added this to the 3.0.0 milestone Jul 30, 2018
lionce pushed a commit to lionce/puppetlabs-kubernetes that referenced this pull request Dec 19, 2019
(maint) Add initial CODEOWNERS file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants