kubernetes::cluster_roles - ignore CNI errors on kubeadm join
#127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merging upstream
k8s 1.10.2 has a bug in joining a cluster where `/var/run/dockershim.sock` doesn't yet exist but `kubeadm join` won't go until it's there. So we work around it by ignoring that error via `manifests/cluster_roles.pp`. Also fixes a version number error in README.md.
|
I just tried to test this in KREAM, and wasn't able to replicate the error. Is it specific to a version of docker or something else? |
|
Apparently? I'm running docker-engine-17.03.1.ce-1.el7.centos.x86_64 + flannel. I found the bug report and fix in a random thread somewhere; this may have been it: I'd also settle for opening up a module parameter to list preflight errors to ignore, I suppose. It's hard to tell what's the best level of complexity for this kind of thing. |
|
I think a parameter sounds like a good idea in this case. |
Sometimes you need to ignore some extra parameters when running 'kubeadm init' or 'kubeadm join'.
|
LGTM, thanks for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
k8s 1.10.2 has a bug in joining a cluster where
/var/run/dockershim.sockdoesn't yet exist butkubeadm joinwon't complete until it's there. So we work around it by ignoring that missing file viamanifests/cluster_roles.pp.Also fixes a version number error in README.md.