Restructure kubenetes::config to kubenetes::config::kubeadm #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorhett
force-pushed
the
name_kubeadm_config_clearly
branch
from
9721324
to
cbd7ca2
Compare
Moves the ambiguous config-version files to version/config_kubeadm for clarity. Cleans up rspec complaints. Should be net zero change in behavior.
jorhett
force-pushed
the
name_kubeadm_config_clearly
branch
from
cbd7ca2
to
2e30d67
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the ambiguous
config-$versiontemplates to$version/config_kubeadmfor clarity.Cleans up rspec complaints.
Should be net zero change in behavior. This is a foundation fix for a number of upcoming PRs, specifically v1beta1 support and new options available within it.