Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store cgroup driver in kubeadm configuration file for kubernetes 1.12+ #259

Merged
merged 1 commit into from
Mar 11, 2019

Conversation

jorhett
Copy link
Contributor

@jorhett jorhett commented Mar 6, 2019

$  kubelet --help |grep cgroup
      --cgroup-driver string

Driver that the kubelet uses to manipulate cgroups on the host.
Possible values: 'cgroupfs', 'systemd' (default "cgroupfs")
(DEPRECATED: This parameter should be set via the config file specified by the Kubelet's --config flag.
 See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information.)

This PR also includes major refactoring to make YAML template build tests less prescriptive and less likely to fail due to minor changes that aren't actual failures.

@jorhett jorhett force-pushed the configurable_cgroup_driver branch from f8e7293 to 752f052 Compare March 8, 2019 21:44
@jorhett jorhett force-pushed the configurable_cgroup_driver branch from 752f052 to da9cf2e Compare March 8, 2019 21:53
@davejrt
Copy link
Contributor

davejrt commented Mar 11, 2019

LGTM

@davejrt davejrt merged commit d1850d0 into puppetlabs:master Mar 11, 2019
@davejrt davejrt added this to the 3.3.0 milestone Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants