add support for cilium network provider

[SimonHoenscheid]

No description provided.

[carabasdaniel]

Hello Simon,

Could you provide an update for the kube_tool to be able to generate the configuration for cilium also ?

For reference: https://github.com/puppetlabs/puppetlabs-kubernetes/blob/master/tooling/kube_tool/other_params.rb#L21

[SimonHoenscheid]

sure!

[carabasdaniel]

Hi @SimonHoenscheid,

Could you please correct this issue with the added version parameter for cni_provider_version

/etc/k8s/kube_tool/other_params.rb:8:in `create': wrong number of arguments (given 8, expected 9) (ArgumentError)
	from /etc/k8s/kube_tool.rb:67:in `build_hiera'
	from /etc/k8s/kube_tool.rb:81:in `<main>'

This is the call that has the missing parameter:
https://github.com/puppetlabs/puppetlabs-kubernetes/blob/master/tooling/kube_tool.rb#L63

I think you might want to set this parameter as optional regarding the fact that for weave and flannel we use the Kubernetes version.

Thanks.

[SimonHoenscheid]

@carabasdaniel I hope the syntax for making the parameter optional is the right one

[carabasdaniel]

@SimonHoenscheid I've tested it and left a few comments. It looks good, but those two issues need to be fixed. When doing the changes please test if the docker image generates the values as intended for two cni-providers (example: weave and cilium).
To build the docker image locally you can use: docker build -t kubetool:latest .
To test for weave you can use for example this command: docker run --rm -v $(pwd):/mnt -e OS=ubuntu -e VERSION=1.13.5 -e CONTAINER_RUNTIME=docker -e CNI_PROVIDER=weave -e ETCD_INITIAL_CLUSTER=kube-master:172.20.20.10 -e ETCD_IP="172.20.10.8" -e KUBE_API_ADVERTISE_ADDRESS="127.0.0.1:443" -e INSTALL_DASHBOARD=true kubetool:latest

[carabasdaniel]

👍 LGTM

[xmulligan]

@SimonHoenscheid Thank you for adding this support! Would you mind adding Puppet to the Cilium adopters list? https://github.com/cilium/cilium/blob/master/USERS.md

We need this for when we apply to graduate at the CNCF

[SimonHoenscheid]

@xmulligan I am not a Puppet Employee and can not say if its ok for Puppet Inc. Please ask @nigelkersten @binford2k.
BTW I am currently reworking the code to use cilium-cli to bootstrap cilium.

[xmulligan]

@nigelkersten @binford2k can you help here?

@SimonHoenscheid glad to hear about cilium-cli ! 🐝

[nigelkersten]

I don’t think I’m the right person, but will see what I can find out! Apologies for the delays in answering.

…

On Fri, 25 Feb 2022 at 10:22, Bill Mulligan ***@***.***> wrote: @nigelkersten <https://github.com/nigelkersten> @binford2k <https://github.com/binford2k> can you help here? @SimonHoenscheid <https://github.com/SimonHoenscheid> glad to hear about cilium-cli ! 🐝 — Reply to this email directly, view it on GitHub <#265 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAACB57CRT3YHVFUEEOQPBTU45J7RANCNFSM4HCWJ4GA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[xmulligan]

@nigelkersten just wanted to circle back on this :) have you found out who the right person it?

[binford2k]

As far as I can tell, we don't actually use Cilium ourselves, we just build some tools that allow our users to use Cilium. It would not be appropriate to add ourselves to that list at this time.

Thanks for following up though!

[xmulligan]

@binford2k Thanks for the update! Feel free to reach out if your users need help with Cilium :)