Use correct apt release on Debian/Ubuntu #338
Conversation
The kubernetes Debian repositories do not make use of codename-specific repositories. Instead a version for all supported releases is available in the "kubernetes-xenial" component. This change hardcodes this component name as the default accordingly. Of course this might brake in the future, but since the value can be overriden via a parameter and this change makes the default work on more distributions (e.g. Ubuntu Bionic) it seems to be a viable solution anyway.
|
@aptituz Thanks for submitting the PR. puppetlabs-kubernetes/manifests/repos.pp Line 27 in 402cb02 Tried to check the value returned by the fact on Debian box and it returns xenial puppetlabs-kubernetes/manifests/repos.pp Line 27 in 402cb02
But In Ubuntu it returns
|
| @@ -28,7 +28,7 @@ | |||
| apt::source { 'kubernetes': | |||
| location => pick($kubernetes_apt_location,'http://apt.kubernetes.io'), | |||
| repos => pick($kubernetes_apt_repos,'main'), | |||
| release => pick($kubernetes_apt_release,"kubernetes-${codename}"), | |||
| release => pick($kubernetes_apt_release,'kubernetes-xenial'), | |||
There was a problem hiding this comment.
Instead of hardcoding the value can we just assign the value to a variable and use the variable.
There was a problem hiding this comment.
What's the benefit of assigning it to a variable if its not used in any other place?
|
Thanks @aptituz for submitting the PR. Ran the adhoc jobs and they ran clean. Thank you. |
The kubernetes Debian repositories do not make use of codename-specific repositories. Instead a version for all supported releases is available in the "kubernetes-xenial" component.
This change hardcodes this component name as the default accordingly. Of course this might break in the future, but since the value can be overriden via a parameter and this change makes the defaults work on a larger set of distributions (e.g. Ubuntu Bionic but probably also Debian) it seems to be a viable solution anyway.
Fixes: #335