Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repair/improve package installation #348

Merged
merged 1 commit into from
Oct 18, 2019
Merged

repair/improve package installation #348

merged 1 commit into from
Oct 18, 2019

Conversation

scoopex
Copy link
Contributor

@scoopex scoopex commented Oct 17, 2019

Sorry for the multiple open/close pull request operations.
I had various problems with my development setup.

- implement the official instructions of
  https://kubernetes.io/docs/setup/production-environment/container-runtimes/ for ubuntu
  and replaced the file_line by a file resource
- created a dependency to "apt-get update" (Class['Apt::Update']) to
  ensure that the index of newly created apt-sources are loaded before
  installing the packages
- improve and enhance tests
@scoopex scoopex requested a review from a team as a code owner October 17, 2019 08:02
Copy link
Contributor

@carabasdaniel carabasdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants