Add possibility to run acceptance tests with Litmus and Vagrant #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carabasdaniel
force-pushed
the
litmus
branch
4 times, most recently
from
52ae1d4
to
6b5016a
Compare
carabasdaniel
force-pushed
the
litmus
branch
2 times, most recently
from
b8f5bd6
to
eb1c7de
Compare
sheenaajay
reviewed
Dec 2, 2019
spec/spec_helper_acceptance.old
Outdated
| on(host, 'rpm -ivh https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm') | ||
| end | ||
| on(host, 'yum update -y -q') if fact_on(host, 'osfamily') == 'RedHat' | ||
| on(host, "yum install -y python-pip", acceptable_exit_codes: [0]).stdout |
There was a problem hiding this comment.
@carabasdaniel too good. Minor comment. We can remove the line number 149,150 and 151, since it's not needed anymore. This change is added to the helm and rook module.
There was a problem hiding this comment.
@sheenaajay Sorry about leaving that in, just removed the spec_helper_acceptance.old file, that was a backup of the original acceptance helper
Codecov Report
@@ Coverage Diff @@
## master #353 +/- ##
=====================================
Coverage 0% 0%
=====================================
Files 2 2
Lines 44 44
=====================================
Misses 44 44Continue to review full report at Codecov.
|
sheenaajay
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.