Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for managing Docker logging max-file and max-size settings. #358

Merged
merged 2 commits into from
Nov 28, 2019
Merged

Add support for managing Docker logging max-file and max-size settings. #358

merged 2 commits into from
Nov 28, 2019

Conversation

nickperry
Copy link
Contributor

Fixes #357

@nickperry nickperry requested a review from a team as a code owner November 27, 2019 12:27
@florindragos
Copy link
Contributor

Hey @nickperry
Thanks for your contribution!
The fix looks good, just need to fix the unit tests. Also, adding some additional tests for the new parameters would be nice.

@carabasdaniel
Copy link
Contributor

👍

@carabasdaniel carabasdaniel merged commit d78b08a into puppetlabs:master Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Control Docker container log file rotation
3 participants
@nickperry @florindragos @carabasdaniel