Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for readOnly and pathType fields on volumes #359

Merged
merged 1 commit into from
Nov 28, 2019
Merged

Add support for readOnly and pathType fields on volumes #359

merged 1 commit into from
Nov 28, 2019

Conversation

nickperry
Copy link
Contributor

This fixes #302 and #304.

Without this PR, the module cannot create functioning volume mounts into the control-plane pods. It is therefore not possible to, for example, mount an audit policy file or mount a directory to write audit logs to.

@nickperry nickperry requested a review from a team as a code owner November 27, 2019 16:14
@carabasdaniel
Copy link
Contributor

Thank you for your contribution @nickperry, this looks good.

@carabasdaniel carabasdaniel merged commit 826e3d2 into puppetlabs:master Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apiserver_extra_volumes and controllermanager_extra_volumes no longer set readOnly attribute (regression)
3 participants