Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure extra_volumes when cloud_provider is set and cloud_config is not. Fixes #301 #361

Merged
merged 2 commits into from
Dec 4, 2019

Conversation

nickperry
Copy link
Contributor

Configure extra_volumes when cloud_provider is set and cloud_config is not. Fixes #301

@nickperry nickperry requested a review from a team as a code owner November 30, 2019 19:18
@nickperry nickperry changed the title Fix 301 Configure extra_volumes when cloud_provider is set and cloud_config is not. Fixes #301 Nov 30, 2019
@codecov-io
Copy link

codecov-io commented Nov 30, 2019

Codecov Report

Merging #361 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #361   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files           2      2           
  Lines          44     44           
=====================================
  Misses         44     44

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaea764...c4a1c95. Read the comment docs.

@sheenaajay
Copy link
Contributor

Thanks for submitting the PR @nickperry . Good job.

@sheenaajay sheenaajay merged commit 3718bd4 into puppetlabs:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extra_volumes not created when cloud_config not set
3 participants