Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker_extra_daemon_config for use when managing docker #376

Merged
merged 2 commits into from
Jan 17, 2020

Conversation

mrwulf
Copy link
Contributor

@mrwulf mrwulf commented Jan 11, 2020

I had been customizing /etc/docker/daemon.json myself to inject registry mirrors and runtime config. This PR allows others to do the same without adding a bunch of individual params.

@mrwulf mrwulf requested a review from a team as a code owner January 11, 2020 00:57
@codecov-io
Copy link

codecov-io commented Jan 12, 2020

Codecov Report

Merging #376 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #376   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files           2      2           
  Lines          44     44           
=====================================
  Misses         44     44

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f604a7...3213a34. Read the comment docs.

@sheenaajay
Copy link
Contributor

Thank you @mrwulf for submitting the PR.Will Run the PR on adhoc pipeline to verify the module tests.Thank you.

@sheenaajay
Copy link
Contributor

Screen Shot 2020-01-17 at 12 07 10

@sheenaajay
Copy link
Contributor

Thank you @mrwulf for submitting the PR.

@sheenaajay sheenaajay merged commit 7b74cb5 into puppetlabs:master Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants