Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(FEAT) Add docker storage options #383

Merged
merged 1 commit into from
Jan 28, 2020
Merged

(FEAT) Add docker storage options #383

merged 1 commit into from
Jan 28, 2020

Conversation

AblionGE
Copy link

Description

Add the ability to specify docker storage options instead of having them hardcoded.

@AblionGE AblionGE requested a review from a team as a code owner January 21, 2020 13:01
@AblionGE
Copy link
Author

Please notice that this PR is started from #382

@codecov-io
Copy link

codecov-io commented Jan 21, 2020 •
edited
Loading

Codecov Report

Merging #383 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #383   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files           2      2           
  Lines          44     44           
=====================================
  Misses         44     44

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e554f39...0b84ef9. Read the comment docs.

@AblionGE AblionGE force-pushed the feature/add_docker_storage_options branch 6 times, most recently from 2365a92 to 5ed453f Compare January 21, 2020 15:48
sanfrancrisko
sanfrancrisko reviewed Jan 23, 2020
View reviewed changes
Copy link
Contributor

@sanfrancrisko sanfrancrisko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank-you for your PR @AblionGE ! I'm looking at it and #382

It would be beneficial to have the functionality in this PR and #382 separated out so they are atomic commits to master. This allows us to keep the CHANGELOG neater and facilitates an easier revert, should we need to go down that path.

I had one question on this PR, if you wouldn't mind having a look?

Thanks again!

manifests/init.pp Show resolved Hide resolved
Add docker storage options
0b84ef9 
update README

fix docker daemon.json template

remove exec-opts option in daemon.json

keep cgroup driver systemd in docker/daemon.json
@AblionGE AblionGE force-pushed the feature/add_docker_storage_options branch from 5ed453f to 0b84ef9 Compare January 26, 2020 09:53
sanfrancrisko
sanfrancrisko approved these changes Jan 27, 2020
View reviewed changes
manifests/init.pp Show resolved Hide resolved
@sanfrancrisko sanfrancrisko merged commit d37baba into puppetlabs:master Jan 28, 2020
@AblionGE AblionGE deleted the feature/add_docker_storage_options branch January 28, 2020 17:18
@sanfrancrisko sanfrancrisko changed the title Feature/add docker storage options (FEAT) Add docker storage options May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanfrancrisko sanfrancrisko sanfrancrisko approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AblionGE @codecov-io @sanfrancrisko